Skip to content

Makefile incorrectly assumes existence of ~/bin #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2024
Merged

Makefile incorrectly assumes existence of ~/bin #135

merged 2 commits into from
Dec 16, 2024

Conversation

obs-gh-scottsolmonson
Copy link
Collaborator

Description

install-ocb target assumed pre-existence of ~/bin
Added non-destructive mkdir before curl operation

Checklist

  • [NA] Created tests which fail without the change (if possible)
  • [NA] Extended the README / documentation, if necessary

obs-gh-mattcotter
obs-gh-mattcotter approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@obs-gh-mattcotter obs-gh-mattcotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this PR without assignees, but it looks good to me! Want to rebase this and land it? Or were you waiting on something?

@obs-gh-scottsolmonson obs-gh-scottsolmonson merged commit 7b7eb8e into main Dec 16, 2024
2 checks passed
@obs-gh-scottsolmonson obs-gh-scottsolmonson deleted the scosol/makefile-fixup branch December 16, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obs-gh-mattcotter obs-gh-mattcotter obs-gh-mattcotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@obs-gh-scottsolmonson @obs-gh-mattcotter